Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI Tests] Added offset and animate parameter to scroll_to, click, and login functions #4545

Merged

Conversation

sushantnadkar
Copy link
Contributor

Purpose:

  • For scenarios where a user might have a fixed banner on their page, simulating a click becomes hard since the element is overlapped by the banner but is inside the viewport of the browser

Images:

Without offset:
image
With offset:
image


Changes made:

  • Added a parameter to control the scroll offset and animation to the click, scroll_to, and login methods

@GSLabIt
Copy link

GSLabIt commented Nov 29, 2017

overlapping Forgot password?

@sushantnadkar sushantnadkar changed the title Added offset and animate parameter to scroll_to, click, and login functions [UI Tests] Added offset and animate parameter to scroll_to, click, and login functions Nov 30, 2017
@sushantnadkar
Copy link
Contributor Author

In the above screenshots, I was taking an example with the SIGN IN button, so the CSS selector was provided for the SIGN IN button. Whatever selector you choose, the offset will be relative to that element with this change.

@rmehta rmehta merged commit 0ca98a0 into frappe:develop Nov 30, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants