Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.x.x Prevent duplicate sidebar display in mobile view #4585

Merged
merged 1 commit into from
Dec 18, 2017
Merged

v8.x.x Prevent duplicate sidebar display in mobile view #4585

merged 1 commit into from
Dec 18, 2017

Conversation

brownharryb
Copy link
Contributor

repeat_sidemenu

On the Portal View, when viewed on mobile, side menu is duplicated, this fixes it.

@@ -515,9 +515,6 @@ a.active {
}

@media (max-width: 767px) {
.visible-xs {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing utility classes is not the correct way of fixing this. You should remove the usage of this class on the element rather.

@netchampfaris
Copy link
Contributor

Please send PRs to develop branch only.

@brownharryb
Copy link
Contributor Author

Hi @netchampfaris
We have a custom app dependent on this branch (v8.x.x).
I have created a PR for develop

@netchampfaris netchampfaris merged commit e8f9fbb into frappe:v8.x.x Dec 18, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants