Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIN] added the Babel Object Rest Plugin #4589

Merged
merged 3 commits into from Dec 12, 2017

Conversation

achillesrasquinha
Copy link
Contributor

@achillesrasquinha achillesrasquinha commented Dec 7, 2017

const alice = { foo: "bar" };
const bob = { bar: "foo" };
const charlie = { ...alice, ...bob };

console.log(charlie);
// { foo: "bar", bar: "foo" }

Used it for my chat! 馃槃

@achillesrasquinha achillesrasquinha changed the title added the Babel Object Rest Plugin [MIN] added the Babel Object Rest Plugin Dec 7, 2017
@netchampfaris
Copy link
Contributor

The spread operator works even without the plugin :)

@achillesrasquinha
Copy link
Contributor Author

How is that? Do we have it used in frappe already?

@achillesrasquinha
Copy link
Contributor Author

Hi, I don't think we do. Object Spread is not available.

Because ECMAScript doesn't have it included (not before 2018) (Still in stage 3 draft - Link to the Proposal).

It doesn't exists within babel-presets-env as well. Issue babel-preset-env 49

@netchampfaris
Copy link
Contributor

Remove package-lock.json

@netchampfaris netchampfaris merged commit c871723 into frappe:develop Dec 12, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants