New data import #4601
Merged
New data import #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manassolanki
force-pushed
the
new-data-import
branch
from
d466b15
to
c3a6d14
Compare
netchampfaris
requested changes
Dec 13, 2017
| frm.reload_doc(); | ||
| } | ||
| if (data.progress) { | ||
| let progress_bar = $(cur_frm.dashboard.progress_area).find(".progress-bar"); |
| title: __('Download Template'), | ||
| fields: [ | ||
| { | ||
| "label": "Select Columns", |
There was a problem hiding this comment.
__('Select Columns')
| frappe.model.with_doctype(frm.doc.reference_doctype, function() { | ||
| if(frm.doc.reference_doctype) { | ||
| // render select columns | ||
| var parent_doctype = frappe.get_doc('DocType', frm.doc.reference_doctype); |
There was a problem hiding this comment.
frappe.get_meta(doctype)
| "fieldtype": "HTML" | ||
| } | ||
| ], | ||
| primary_action: function() { |
There was a problem hiding this comment.
primary_action: function(values) {
| } | ||
| ], | ||
| primary_action: function() { | ||
| var data = download_dialog.get_values(); |
|
|
||
| def as_link(doctype, name): | ||
| if via_console: | ||
| return "{0}: {1}".format(doctype, name) | ||
| else: | ||
| return getlink(doctype, name) | ||
|
|
||
| error = False | ||
| total = len(data) | ||
| def get_link(doctype, name): |
There was a problem hiding this comment.
there is already a method called get_url_to_form
| <div class="table-responsive"> | ||
| <table class="table table-bordered table-hover log-details-table"> | ||
| <tr class=""> | ||
| <th style="width:10%"> Row No </th> |
| // rename this file from _test_[name] to test_[name] to activate | ||
| // and remove above this line | ||
|
|
||
| QUnit.test("test: Data Import", function (assert) { |
manassolanki
force-pushed
the
new-data-import
branch
from
db232a1
to
e1a4b8e
Compare
manassolanki
force-pushed
the
new-data-import
branch
from
e1a4b8e
to
8df72aa
Compare
netchampfaris
requested changes
Dec 14, 2017
| } | ||
| }, | ||
| { | ||
| "label": "File Type", |
| "default": "Excel" | ||
| }, | ||
| { | ||
| "label": "Download with Data", |
manassolanki
force-pushed
the
new-data-import
branch
from
8df72aa
to
4f23463
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Data Import Tool
Fixes frappe/erpnext#11474, frappe/erpnext#10712, frappe/erpnext#11443
Export Template
Data Import