Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[export-fields] export comma separated lines for long values #4667

Merged
merged 3 commits into from Dec 22, 2017
Merged

[export-fields] export comma separated lines for long values #4667

merged 3 commits into from Dec 22, 2017

Conversation

pratu16x7
Copy link
Contributor

@pratu16x7 pratu16x7 commented Dec 21, 2017 •
edited

frappe/erpnext#12085

before:
screen shot 2017-12-21 at 5 07 05 pm

after:
screen shot 2017-12-21 at 5 26 24 pm

manassolanki
manassolanki reviewed Dec 22, 2017
View reviewed changes
frappe/utils/xlsxutils.py
else:
return value[1]

value = ", ".join(value.split(' \n'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets only add value = ", ".join(value.split(' \n')) after the value = obj.handle(h) to handle the br html tag.

@manassolanki manassolanki merged commit ae0234e into frappe:develop Dec 22, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manassolanki manassolanki manassolanki left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pratu16x7 @manassolanki