Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New build system: Webpack ✨ 📦 📑 #4902

Closed
wants to merge 28 commits into from
Closed

New build system: Webpack ✨ 📦 📑 #4902

wants to merge 28 commits into from

Conversation

netchampfaris
Copy link
Contributor

@netchampfaris netchampfaris commented Jan 23, 2018 •
edited

  • Link field in Grid
  • TextEditor styles
  • WebForm

achillesrasquinha and others added 21 commits December 12, 2017 17:32
@rmehta
Copy link
Member

rmehta commented Jan 23, 2018

Resolve conflicts and merge this fast! Also add a discuss post.

rmehta
rmehta reviewed Jan 23, 2018
View reviewed changes
frappe/core/doctype/page/page.py Outdated
@@ -12,6 +12,19 @@
from frappe.core.doctype.custom_role.custom_role import get_custom_allowed_roles
from six import text_type

# from webpack.compiler import webpack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code?

rmehta
rmehta reviewed Jan 23, 2018
View reviewed changes
frappe/npm-debug.log
@@ -0,0 +1,49 @@
0 info it worked if it ends with ok
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitignore ?

rmehta
rmehta reviewed Jan 23, 2018
View reviewed changes
frappe/public/js/frappe/form/controls/geolocation.js Outdated
@@ -1,3 +1,12 @@
// import "../js/lib/leaflet/leaflet.css";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments?

rmehta
rmehta reviewed Jan 23, 2018
View reviewed changes
frappe/public/script.py Outdated
@@ -0,0 +1,27 @@
import os
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temp script?

rmehta
rmehta reviewed Jan 23, 2018
View reviewed changes
frappe/www/desk.html Outdated
@@ -48,15 +46,19 @@

if(!window.frappe) window.frappe = {};

frappe.boot = {{ boot }};
{#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

@netchampfaris netchampfaris mentioned this pull request Jan 24, 2018
Closed
@rmehta
Copy link
Member

rmehta commented Jan 31, 2018

lets use rollupjs

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmehta rmehta rmehta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@netchampfaris @rmehta @achillesrasquinha @pratu16x7