Raise exception while deleting an item which is a product bundle #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmehta
previously requested changes
Apr 6, 2018
frappe/model/delete_doc.py
Outdated
| @@ -193,7 +193,7 @@ def check_if_doc_is_linked(doc, method="Delete"): | |||
| # don't check for communication and todo! | |||
| continue | |||
|
|
|||
| if item and ((item.parent or item.name) != doc.name) \ | |||
| if item and (link_dt != doc.doctype or ((item.parent or item.name) != doc.name)) \ | |||
There was a problem hiding this comment.
this condition is too complex! please break it down
shreyashah115
force-pushed
the
raise-exception-for-product-bundle
branch
from
17e824a
to
864b4c9
Compare
shreyashah115
force-pushed
the
raise-exception-for-product-bundle
branch
from
6898c41
to
c3a5911
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exception is not raised while deleting an item which is also a product bundle item as the docname of product bundle is same as the item name. So, also check if the doctype being deleted is not same as the linked doctype.
Issue:
Fix:
Closes: frappe/erpnext#13027