Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed bad code and made compatible with pip 10 #5458

Merged
merged 1 commit into from Apr 30, 2018
Merged

removed bad code and made compatible with pip 10 #5458

merged 1 commit into from Apr 30, 2018

Conversation

codingCoffee
Copy link
Contributor

No description provided.

@krnkris
Copy link
Contributor

krnkris commented Apr 17, 2018

Hello @codingCoffee
Is it related?

https://discuss.erpnext.com/t/how-to-fix-this-botocore-requirement/35835/5

&

#5446

@krnkris krnkris mentioned this pull request Apr 17, 2018
Closed
@codingCoffee
Copy link
Contributor Author

@krnkris yup it's related

@rmehta
Copy link
Member

rmehta commented Apr 26, 2018

@codingCoffee what is the update on this?

@codingCoffee
Copy link
Contributor Author

@rmehta I don't remember why the don't-merge flag was put.
But I tested the installation, it works perfectly. Also another PR along the same lines frappe/erpnext#13805 . Also merge-able

@nabinhait nabinhait merged commit c6e4699 into frappe:hotfix Apr 30, 2018
shridarpatil pushed a commit to zerodha/frappe that referenced this pull request May 29, 2018
@codingCoffee @shridarpatil
removed bad code and made compatible with pip 10 (frappe#5458)
b47675d
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codingCoffee @krnkris @rmehta @nabinhait