Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using regex instead of soup to parse pdf page margins #5883

Merged
merged 2 commits into from
Jul 30, 2018

Conversation

shreyashah115
Copy link
Contributor

cherry-pick from develop, related to #4972

@rmehta rmehta merged commit 4c20d1f into frappe:hotfix Jul 30, 2018
@skjbulcher
Copy link
Contributor

I'm thoroughly confused by this commit. It

  • artificially limits values to those ending in mm; (it ignores "page-size", who's value doesn't end in mm;), and
  • ignores the metric.

Is that intentional? I see more recent code adding options like "header-spacing" and "orientation", which are all ignored as well since their values don't end in mm;.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants