Quill editor #6159
Merged
Quill editor #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 lets also include indent / outdent buttons |
- prevent default events
- Use quill's bubble theme for comment control
- Uses quill-mention package
- Remove comment.js (use fieldtype: 'Comment') - Add quill styles to webform.css
netchampfaris
force-pushed
the
quill-editor
branch
from
b4fe3e1
to
e497ee5
Compare
netchampfaris
added a commit
to netchampfaris/erpnext
that referenced
this pull request
Sep 30, 2018
rmehta
pushed a commit
to frappe/erpnext
that referenced
this pull request
Sep 30, 2018
|
Hi @netchampfaris, Hope you're doing well. This PR might be causing an issue while building JS files in the
Please review. |
|
@sagarvora Quill was added as an npm dependency. You need to download it using |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to retire summernote!
TODO: