Change Email Signature fieldtype #6161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change fieldtype from Text to Text Editor - Add patch to handle cases having a new line
rmehta
requested changes
Sep 28, 2018
| frappe.reload_doc('core', 'doctype', 'user') | ||
| for d in signatures: | ||
| signature = d.get('email_signature') | ||
| signature = signature.replace('\n', '<br>') |
There was a problem hiding this comment.
signature = frappe.markdown(signature) ?
There was a problem hiding this comment.
frappe.markdown is written on client side, so can't use it in patch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Pull Request Checklist to ensure you have everything that is needed to get your contribution merged.