Fix Routing while adding address #6171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyashah115
force-pushed
the
fix-routing
branch
from
6a157d7
to
a93a2a5
Compare
rmehta
requested changes
Oct 1, 2018
| } | ||
| } | ||
| ]); | ||
| }, | ||
| get_last_doc() { |
shreyashah115
force-pushed
the
fix-routing
branch
from
da7ed9a
to
a28b528
Compare
rmehta
requested changes
Oct 2, 2018
| @@ -0,0 +1,21 @@ | |||
| // Copyright (c) 2018, Frappe Technologies and contributors | |||
There was a problem hiding this comment.
there is already another address_and_contact.js
https://github.com/frappe/frappe/blob/develop/frappe/public/js/frappe/misc/address_and_contact.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
While adding a new address to a Lead / Customer Form, sometimes, the last route is incorrectly picked and messes up the dynamic linking and routing in Address.
Fix:
Thanks for the help @netchampfaris