fix: Customize Form and Custom DocType related fixes #6645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great. Can you also add tests? |
netchampfaris
previously requested changes
Dec 21, 2018
Zlash65
force-pushed
the
fix-custom
branch
2 times, most recently
from
6374d17
to
b84cbb4
Compare
sagarvora
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom DocType should not be allowed to be edited through Customize Form
Issue:-
Fix:-
Allow on submit not visible for child tables
Fix:-
Using Custom Field to add fields to a Custom DocType
*Bad Practice - Making a Custom
DocTypeand then usingCustom FieldDocType to add fields to that custom DocType.Issue:-
Fix:-
