Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(list-view): Show count that matches number of rows #6798

Merged
merged 1 commit into from Jan 22, 2019
Merged

fix(list-view): Show count that matches number of rows #6798

merged 1 commit into from Jan 22, 2019

Conversation

adityahase
Copy link
Member

In following scenario

DocType DT2

DocType DT1
	DT2 Table field DT1C

DocType DT1C (Child Table in DT1)
	DT2 Link Field DT2

Filtering based on child table fields shows incorrect count of rows

Rows in list are grouped by name, but the count string shows count that matches number of child table rows

Note: Notice the count string e.g. 1 of 1 and 1 of 2

Before fix
screenshot 2019-01-21 at 5 45 25 pm

After fix
screenshot 2019-01-21 at 5 43 14 pm

@nabinhait nabinhait merged commit b2f559c into frappe:staging-fixes Jan 22, 2019
scmmishra pushed a commit to scmmishra/frappe that referenced this pull request Jan 28, 2019
@adityahase @scmmishra
fix(list-view): Show count that matches number of rows (frappe#6798)
d8aca36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmehta rmehta Awaiting requested review from rmehta

@nabinhait nabinhait Awaiting requested review from nabinhait

@netchampfaris netchampfaris Awaiting requested review from netchampfaris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adityahase @nabinhait