fix: Use ImportError instead of ModuleNotFoundError #6808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adityahase
commented
Jan 22, 2019
adityahase
commented
- ModuleNotFoundError is available in python 3.6
- ImportError works in python 2 and 3 and 3.4 and 3..5 and 3.6 and so on
- This should have been included in Frappe PR fix: Use ImportError instead of ModuleNotFoundError #6797
ModuleNotFoundError is available in python 3.6 This should have been included in Frappe PR frappe#6797
adityahase
force-pushed
the
fix-import
branch
from
b0e1149
to
eda1c05
Compare
netchampfaris
approved these changes
Jan 23, 2019
scmmishra
pushed a commit
to scmmishra/frappe
that referenced
this pull request
Jan 28, 2019
ModuleNotFoundError is available in python 3.6 This should have been included in Frappe PR frappe#6797
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.