fix(PrintFormat): Section Labels with spaces in them got truncated #6819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
screenshot? |
|
@saurabh6790 Difficult to show a visual proof, I have explained my solution in the description. |
|
Is it reproducible? If yes, then there should be before and after screenshots. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you save a Print Format from the Print Format Builder, it builds a JSON of the format with all the settings to reproduce that format. This also includes Section Labels. Section Labels are fetched from the HTML itself, specifically
data-labelattribute. This attribute breaks if you have spaces in your value and you don't have quotes around them.Here is the issue: