Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Casting docnames and handling unicode #6822

Merged
merged 1 commit into from
Jan 25, 2019
Merged

fix: Casting docnames and handling unicode #6822

merged 1 commit into from
Jan 25, 2019

Conversation

Zlash65
Copy link
Contributor

@Zlash65 Zlash65 commented Jan 24, 2019 

x = u'["\u6ce5\u677f\u5f00\u53d1", "\u7f8e\u56e2\u56de\u6536"]'
il = sorted(json.loads(x), reverse=True, key=str)

Works for python 3 but fails for python 2

@nabinhait nabinhait merged commit d8187a3 into frappe:staging-fixes Jan 25, 2019
scmmishra pushed a commit to scmmishra/frappe that referenced this pull request Jan 28, 2019
@Zlash65 @scmmishra
fix: unicode character throws error for python 2 (frappe#6822)
e69c914
@Zlash65 Zlash65 deleted the min-py23-fix branch March 4, 2019 04:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adityahase adityahase adityahase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zlash65 @adityahase @nabinhait