Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return empty dict if setup wizard is not completed #6830

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

saurabh6790
Copy link
Member

@saurabh6790 saurabh6790 commented Jan 24, 2019

  1. When returns empty result

screen shot 2019-01-24 at 10 16 07 pm

  1. when returns empty dict, the system does not load setup wizard though setup wizard is no completed

screen shot 2019-01-24 at 10 17 28 pm

  1. Fix:
    Return dict with empty count
return {
     "open_count_doctype": {},
     "open_count_module": {},
     "open_count_other": {},
     "targets": {},
     "new_messages": []
}

@nabinhait nabinhait merged commit 97152b5 into frappe:staging-fixes Jan 25, 2019
scmmishra pushed a commit to scmmishra/frappe that referenced this pull request Jan 28, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants