Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(desk): Use key matching label if key with fieldname doesn't exist #6839

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

adityahase
Copy link
Member

For example for Item Variant Details with following data
screenshot 2019-01-28 at 3 53 51 pm

Report exported as Excel doesn't include data for some of the columns

Before
screenshot 2019-01-28 at 3 57 20 pm

After
screenshot 2019-01-28 at 3 57 38 pm

@sagarvora
Copy link
Collaborator

The parentheses in your PR title must match the affected module (e.g. accounts).

@adityahase
Copy link
Member Author

The parentheses in your PR title must match the affected module (e.g. accounts).

This fixes "reports", Item Variant Details is just an example.

@sagarvora
Copy link
Collaborator

This fixes "reports", Item Variant Details is just an example.

The module is desk.

@adityahase adityahase changed the title fix(report): Use key matching label if key with fieldname doesn't exist fix(desk): Use key matching label if key with fieldname doesn't exist Jan 29, 2019
@nabinhait nabinhait merged commit e4224ea into frappe:staging-fixes Jan 29, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants