Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Remove limits from frappe #7662

Merged
merged 14 commits into from Jul 29, 2019
Merged

BREAKING CHANGE: Remove limits from frappe #7662

merged 14 commits into from Jul 29, 2019

Conversation

deepeshgarg007
Copy link
Member

No description provided.

rmehta
rmehta previously requested changes Jun 12, 2019
View reviewed changes
frappe/core/doctype/user/test_user.py Outdated Show resolved Hide resolved
@deepeshgarg007 deepeshgarg007 changed the title fix: Remove user limit check from frappe fix: Remove limits from frappe Jun 30, 2019
surajshetty3416
surajshetty3416 previously approved these changes Jul 4, 2019
View reviewed changes
@surajshetty3416 surajshetty3416 dismissed their stale review July 4, 2019 06:13

wait for other PR

@scmmishra
Copy link
Contributor

@deepeshgarg007 Please add a description to your PR.

@Don-Leopardo
Copy link
Contributor

Don-Leopardo commented Jul 10, 2019 •
edited

@deepeshgarg007 Can I ask why?

@rmehta
Copy link
Member

rmehta commented Jul 11, 2019

This can easily be implemented via hooks and this was a pretty bad implementation too

@rmehta rmehta changed the title fix: Remove limits from frappe BREAKING CHANGE: Remove limits from frappe Jul 11, 2019
@mhbu50
Copy link
Contributor

mhbu50 commented Jul 16, 2019

@rmehta how will implement?
should we create it in the custom app or it will be in the core?

@deepeshgarg007 deepeshgarg007 dismissed rmehta’s stale review July 29, 2019 06:37

Removed commented code

@netchampfaris netchampfaris merged commit dfa16a7 into frappe:develop Jul 29, 2019
@mhbu50
Copy link
Contributor

mhbu50 commented Jul 30, 2019

@rmehta @netchampfaris Could you give an Answer?

@rmehta
Copy link
Member

rmehta commented Jul 30, 2019

@mhbu50 Like I said, this logic is best moved to custom app as after the limits there will be additional workflow that will have to be handled by your billing platform.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@netchampfaris netchampfaris netchampfaris approved these changes

@rmehta rmehta rmehta left review comments

@surajshetty3416 surajshetty3416 surajshetty3416 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@deepeshgarg007 @scmmishra @Don-Leopardo @rmehta @mhbu50 @netchampfaris @surajshetty3416 @frappe-bot