fix: Disable caching for respond_as_web_page response #8276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netchampfaris
requested changes
Aug 27, 2019
frappe/__init__.py
Outdated
| @@ -1190,6 +1193,7 @@ def respond_as_web_page(title, html, success=None, http_status_code=None, | |||
| context['primary_action'] = primary_action | |||
| context['error_code'] = http_status_code | |||
| context['fullpage'] = fullpage | |||
| context['no_cache'] = no_cache | |||
There was a problem hiding this comment.
respond_as_web_page should always be uncached
netchampfaris
approved these changes
Aug 27, 2019
surajshetty3416
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow confirmation page always used to show old cached document approval page if multiple links are clicked simultaneously for approval.
Solution: Disable caching for respond_as_web_page response