Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security): Make all Prepared Report file attachments private #8884

Merged
merged 1 commit into from
Nov 26, 2019
Merged

fix(security): Make all Prepared Report file attachments private #8884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion frappe/core/doctype/prepared_report/prepared_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ def create_json_gz_file(data, dt, dn):
"file_name": json_filename,
"attached_to_doctype": dt,
"attached_to_name": dn,
"content": compressed_content
"content": compressed_content,
"is_private": 1
})
_file.save(ignore_permissions=True)

Expand Down
1 change: 1 addition & 0 deletions frappe/patches.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,3 +257,4 @@ frappe.patches.v12_0.setup_tags
frappe.patches.v12_0.update_auto_repeat_status_and_not_submittable
frappe.patches.v12_0.copy_to_parent_for_tags
frappe.patches.v12_0.create_notification_settings_for_user
frappe.patches.v11_0.make_all_prepared_report_attachments_private
10 changes: 10 additions & 0 deletions frappe/patches/v11_0/make_all_prepared_report_attachments_private.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
from __future__ import unicode_literals
import frappe


def execute():
files = frappe.get_all("File", filters={"attached_to_doctype": "Prepared Report", "is_private": 0})
for file_name in files:
file_doc = frappe.get_doc("File", file_name)
file_doc.is_private = 1
file_doc.save()