feat: Validate Data options and Data values #9784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for fieldtype "Data" and options set to "Email" or "Phone", updating
documents will trigger data validations for email and phone numbers will be made
added set_invalid control for docfields. On event of docfield.invalid is set, in a given form, set_invalid will be executed which changes the textbox colour to red
returning empty string if parseaddr returns None shows " is not a valid Email Address" eg: if 'email@' is passed as value, email.utils.parseaddr will return a (None, None) tuple
gavindsouza
force-pushed
the
data-options
branch
from
01d9aaa
to
5627981
Compare
surajshetty3416
requested changes
Mar 26, 2020
surajshetty3416
changed the title
gavindsouza
force-pushed
the
data-options
branch
from
7525be5
to
a8e1e1c
Compare
surajshetty3416
previously approved these changes
Mar 30, 2020
fix: circular import
gavindsouza
force-pushed
the
data-options
branch
3 times, most recently
from
b17da92
to
ec837a5
Compare
gavindsouza
force-pushed
the
data-options
branch
from
ec837a5
to
6478eb1
Compare
gavindsouza
force-pushed
the
data-options
branch
from
6478eb1
to
25d260d
Compare
surajshetty3416
requested changes
Apr 1, 2020
gavindsouza
force-pushed
the
data-options
branch
from
37bc19e
to
9393c05
Compare
surajshetty3416
previously approved these changes
Apr 1, 2020
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
gavindsouza
force-pushed
the
data-options
branch
from
2a75274
to
6eecea2
Compare
gavindsouza
force-pushed
the
data-options
branch
from
6eecea2
to
a8af9e9
Compare
|
In submitted documents, if "Allow on submit" is enabled for certain fields, when the document is validated again, in case the Data fields throw ValidationError, the user may not be able to update those fields. This feature will stay in |
This was referenced Apr 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DocType Validations:
Document Validations:
Client Side Validation:
Server Side Validation:
Other fixes:
Docs Link