Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase the length of the password #9969

Merged
merged 1 commit into from Apr 16, 2020
Merged

fix: increase the length of the password #9969

merged 1 commit into from Apr 16, 2020

Conversation

Mangesh-Khairnar
Copy link
Contributor

@Mangesh-Khairnar Mangesh-Khairnar commented Apr 16, 2020 •
edited

  • Increase the length of the password field to 127 which is maximum under the given structure of auth table(255 characters)
  • Allows to save secret key/ authorization code generated for integrated apps which are generally over the 100 limit

photo_2020-04-16 15 26 57

@Mangesh-Khairnar Mangesh-Khairnar requested a review from a team as a code owner April 16, 2020 08:59
@Mangesh-Khairnar Mangesh-Khairnar requested review from Thunderbottom and removed request for a team April 16, 2020 08:59
@Mangesh-Khairnar Mangesh-Khairnar mentioned this pull request Apr 16, 2020
Merged
Thunderbottom
Thunderbottom approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@Thunderbottom Thunderbottom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! although i think we can have it > 127 characters as well. feel free to increase the number if it works fine

@mergify mergify bot merged commit 104381a into frappe:develop Apr 16, 2020
This was referenced Jul 17, 2020
Merged
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Thunderbottom Thunderbottom Thunderbottom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mangesh-Khairnar @Thunderbottom