Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added guide for linux/mac to setup frappe docker #1149

Merged
merged 3 commits into from Jun 12, 2023
Merged

Conversation

KMJ-007
Copy link
Contributor

@KMJ-007 KMJ-007 commented Jun 11, 2023

Please provide enough information so that others can review your pull request:

the current version of pwd.yml wasn't working

because it was not able to find the correct images from docker,

error i was getting:
image

Explain the details for making this change. What existing problem does the pull request solve?

I added one guide in the documentation to run the frappe docker on linux and mac

in which i added platform in the yml file

i tried on two M1 computer, and it is working

image

@revant
Copy link
Collaborator

revant commented Jun 12, 2023

can you also add it on main readme under Production or Development wherever you feel fit?

Make sure you also execute this locally https://github.com/frappe/frappe_docker/blob/main/CONTRIBUTING.md#lint

@KMJ-007
Copy link
Contributor Author

KMJ-007 commented Jun 12, 2023

done!

@revant revant merged commit a6e1baa into frappe:main Jun 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants