Add a flag to skip generating default NGINX config #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will help serving custom non python apps https://discuss.erpnext.com/t/how-add-nodejs-app-to-frappe-bench/14276 |
mr-karan
changed the title
|
@revant Rebased the changes. Is there anything else required for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
SKIP_NGINX_TEMPLATE_GENERATIONenvironment variable support tofrappe-nginx/docker-entrypoint.sh. The behavior is:1, will skip theenvsubstpart and the user is expected to mount their own config file.0), will continue the current behavior of generating the config file fromnginx-default.conf.template.Discussed in #441 (comment). Marking it as WIP since I'd need to rebase this once #441 gets merged.