Update configuring-https.md #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated changes to include steps for certificate from private authority https://discuss.erpnext.com/t/tutorial-how-to-setup-a-purchased-ssl-certificate-on-erpnext-site/48664
|
Could we have two separate sections? One for generating using LetsEncrypt and the other through any Private Certificate Authority? I don't think that mixing them together is a good idea. Also being clear about the differences between both would be a good idea. I hope it's not much to ask for. Let me know if you need any help. |
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
Thunderbottom
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated changes to include steps for certificate from private authority
https://discuss.erpnext.com/t/tutorial-how-to-setup-a-purchased-ssl-certificate-on-erpnext-site/48664