Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make service unit type mandatory for all non-group types #225

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

ChillarAnand
Copy link
Contributor

No description provided.

@akurungadam
Copy link
Collaborator

@ChillarAnand thanks for this, but you know for group nodes service_unit_type may not be relevant

@ChillarAnand ChillarAnand force-pushed the hsu-bug branch 2 times, most recently from 19b7910 to 25c13a8 Compare April 20, 2023 05:11
@ChillarAnand
Copy link
Contributor Author

@akurungadam Yeah, you are right. Right now, in quick entry, for non-group, the mandatory option is not showing up. Updated condition for it.

@ChillarAnand ChillarAnand changed the title fix: Make service unit type mandatory in service unit fix: Make service unit type mandatory for all non-group types Apr 20, 2023
@akashkrishna619 akashkrishna619 merged commit 19a4e30 into frappe:develop Apr 21, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants