Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: settings: add a check to instantly send email #1061

Merged
merged 1 commit into from Mar 15, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Mar 15, 2023

This PR adds a check in Frappe Desk Settings to decide if the reply e-mail should be sent instantly (instead of adding to a queue)

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 12.50% and no project coverage change.

Comparison is base (7d7c6b8) 12.47% compared to head (be30327) 12.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1061   +/-   ##
=======================================
  Coverage   12.47%   12.47%           
=======================================
  Files          52       52           
  Lines        1739     1747    +8     
=======================================
+ Hits          217      218    +1     
- Misses       1522     1529    +7     
Impacted Files Coverage Δ
frappedesk/frappedesk/doctype/ticket/ticket.py 21.71% <12.50%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad merged commit fbc352f into frappe:main Mar 15, 2023
7 checks passed
@ssiyad ssiyad deleted the feat/settings_instant_email branch March 15, 2023 17:05
@ssiyad ssiyad added the enhancement New feature or request label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant