Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ux): ticket details: show save button only if there is a change #1204

Merged

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented May 19, 2023

  • Show save button only if there is a change
  • Change background color (darken, bg-gray-900)

@ssiyad ssiyad added the enhancement New feature or request label May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 35.00% and project coverage change: +0.45 🎉

Comparison is base (75e655f) 12.87% compared to head (db49438) 13.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1204      +/-   ##
==========================================
+ Coverage   12.87%   13.33%   +0.45%     
==========================================
  Files          52       52              
  Lines        1848     1852       +4     
==========================================
+ Hits          238      247       +9     
+ Misses       1610     1605       -5     
Impacted Files Coverage Δ
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 22.92% <15.38%> (+0.40%) ⬆️
helpdesk/utils.py 35.00% <66.66%> (+35.00%) ⬆️
helpdesk/__init__.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ssiyad ssiyad merged commit 455e475 into frappe:main May 19, 2023
8 checks passed
@ssiyad ssiyad deleted the feat/ux/ticket_save_visibility_conditional branch May 19, 2023 11:42
kurogeek pushed a commit to kurogeek/helpdesk that referenced this pull request May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant