Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to prefer knowledge base #1340

Merged
merged 1 commit into from Jul 25, 2023

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Jul 25, 2023

If enabled,

  • redirect to knowledge base
  • hide new ticket button

If enabled,
- redirect to knowledge base
- hide `new ticket` button
@ssiyad ssiyad added the enhancement New feature or request label Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.47% 🎉

Comparison is base (75e655f) 12.87% compared to head (fddf860) 13.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
+ Coverage   12.87%   13.35%   +0.47%     
==========================================
  Files          52       56       +4     
  Lines        1848     1955     +107     
==========================================
+ Hits          238      261      +23     
- Misses       1610     1694      +84     
Files Changed Coverage Δ
helpdesk/__init__.py 100.00% <ø> (ø)
helpdesk/consts.py 100.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_agent/hd_agent.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_article/api.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_article/hd_article.py 0.00% <ø> (ø)
...lpdesk/helpdesk/doctype/hd_article_category/api.py 0.00% <ø> (ø)
...doctype/hd_article_category/hd_article_category.py 0.00% <ø> (ø)
...hd_desk_account_request/hd_desk_account_request.py 0.00% <ø> (ø)
...k/doctype/hd_escalation_rule/hd_escalation_rule.py 0.00% <ø> (ø)
helpdesk/helpdesk/doctype/hd_ticket/hd_ticket.py 22.82% <ø> (+0.30%) ⬆️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssiyad ssiyad merged commit 9bb5886 into frappe:main Jul 25, 2023
8 checks passed
@ssiyad ssiyad deleted the feat/knowledge_base_prefer branch July 25, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant