refactor: edit field names for appraisal cycle

frappe · Apr 23, 2024 · 012e060 · 012e060
1 parent cc42051
commit 012e060
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/hrms/hr/doctype/appraisal/appraisal.py b/hrms/hr/doctype/appraisal/appraisal.py
@@ -185,7 +185,7 @@ def calculate_final_score(self):
 			appraisal_cycle_doc = frappe.get_doc("Appraisal Cycle", self.appraisal_cycle)
 
 			formula = appraisal_cycle_doc.final_score_formula
-			based_on_formula = appraisal_cycle_doc.calculate_final_score_based_on_formula
+			based_on_formula = appraisal_cycle_doc.calculate_final_score_using_custom_formula
 
 			if not based_on_formula:
 				final_score = (

diff --git a/hrms/hr/doctype/appraisal_cycle/appraisal_cycle.json b/hrms/hr/doctype/appraisal_cycle/appraisal_cycle.json
@@ -17,7 +17,7 @@
   "section_break_4",
   "description",
   "settings_section",
-  "calculate_final_score_based_on_formula",
+  "calculate_final_score_using_custom_formula",
   "final_score_formula",
   "column_break_wpgg",
   "kra_evaluation_method",
@@ -159,7 +159,7 @@
    "read_only": 1
   },
   {
-   "depends_on": "eval:doc.calculate_final_score_based_on_formula === 1;",
+   "depends_on": "eval:doc.calculate_final_score_using_custom_formula === 1;",
    "fieldname": "final_score_formula",
    "fieldtype": "Code",
    "label": "Final Score Formula",
@@ -168,9 +168,9 @@
   },
   {
    "default": "0",
-   "fieldname": "calculate_final_score_based_on_formula",
+   "fieldname": "calculate_final_score_using_custom_formula",
    "fieldtype": "Check",
-   "label": "Calculate final score based on formula"
+   "label": "Calculate final score using custom formula"
   },
   {
    "fieldname": "column_break_wpgg",
@@ -192,7 +192,7 @@
    "link_fieldname": "appraisal_cycle"
   }
  ],
- "modified": "2024-04-16 13:15:55.493958",
+ "modified": "2024-04-23 11:42:45.863283",
  "modified_by": "Administrator",
  "module": "HR",
  "name": "Appraisal Cycle",

diff --git a/hrms/hr/doctype/appraisal_cycle/test_appraisal_cycle.py b/hrms/hr/doctype/appraisal_cycle/test_appraisal_cycle.py
@@ -68,7 +68,7 @@ def create_appraisal_cycle(**args):
 			"company": args.company or "_Test Appraisal",
 			"start_date": args.start_date or "2022-01-01",
 			"end_date": args.end_date or "2022-03-31",
-			"calculate_final_score_based_on_formula": based_on_formula,
+			"calculate_final_score_using_custom_formula": based_on_formula,
 		}
 	)
 	if based_on_formula: