fix: make promotion details table non-mandatory #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- only CTC can be updated without any other branch/dept/designation change
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #559 +/- ##
===========================================
- Coverage 73.17% 73.16% -0.01%
===========================================
Files 190 190
Lines 9871 9873 +2
===========================================
+ Hits 7223 7224 +1
- Misses 2648 2649 +1
|
mergify bot
pushed a commit
that referenced
this pull request
May 31, 2023
(cherry picked from commit 5d10fd9)
ruchamahabal
added a commit
that referenced
this pull request
May 31, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 31, 2023
# [14.4.0](v14.3.4...v14.4.0) (2023-05-31) ### Bug Fixes * check if shift is outside assignment period ([1ef0954](1ef0954)) * consider `curr_shift` to retrieve `prev_shift` when possible ([a4889b0](a4889b0)) * make promotion details table non-mandatory (backport [#559](#559)) ([#560](#560)) ([751adf4](751adf4)) * midnight shift not fetched in checkin if assignment is missing on shift's end date ([ab4f980](ab4f980)) * rectify time overlap validation for midnight shifts ([21e71e8](21e71e8)) * remove rounding default for earned leave (backport [#547](#547)) ([#549](#549)) ([8da0656](8da0656)) * set default to zero on salary component. ([#552](#552)) ([d846d84](d846d84)) ### Features * Allow ceil & floor functions in salary slip formulae (backport [#527](#527)) ([#558](#558)) ([f8bb10c](f8bb10c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make promotion details table non-mandatory
Only CTC can be updated without any other branch/dept/designation change