Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Leave Ledger Report #1381

Merged
merged 10 commits into from
Apr 7, 2024

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Feb 3, 2024

image

View Ledger buttons in transactions:

leave-ledger.mp4

Docs: https://frappehr.com/docs/v14/en/leave-ledger-report

@ruchamahabal ruchamahabal changed the title feat: Leave Ledger report feat: Leave Ledger Report Feb 3, 2024
@ruchamahabal ruchamahabal force-pushed the leave-ledger-report branch 3 times, most recently from 33ddb33 to fa0b372 Compare February 3, 2024 18:54
@ruchamahabal ruchamahabal marked this pull request as draft February 3, 2024 19:01
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 72.90%. Comparing base (218016a) to head (99e274a).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1381      +/-   ##
===========================================
+ Coverage    72.78%   72.90%   +0.12%     
===========================================
  Files          202      203       +1     
  Lines        11195    11240      +45     
===========================================
+ Hits          8148     8195      +47     
+ Misses        3047     3045       -2     
Files Coverage Δ
hrms/hr/report/leave_ledger/leave_ledger.py 95.55% <95.55%> (ø)

... and 2 files with indirect coverage changes

@ruchamahabal ruchamahabal marked this pull request as ready for review April 7, 2024 09:28
@ruchamahabal ruchamahabal merged commit 72aa69e into frappe:develop Apr 7, 2024
7 checks passed
ruchamahabal added a commit that referenced this pull request Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants