Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show holidays and colour code in attendance calendar #1595

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

vinyselopal
Copy link
Contributor

@vinyselopal vinyselopal commented Mar 28, 2024

Description: Show holidays and colour code for each employee in attendance calendar

Before:
Screenshot 2024-03-28 at 12 39 03 PM

After:
Screenshot 2024-03-28 at 12 34 35 PM

Closes #1311 Closes #1173
no-docs (does not require docs as its just a visual enhancement)

@vinyselopal vinyselopal force-pushed the add-holidays-to-attendance-calendar branch from 85c80ce to 4e39521 Compare March 28, 2024 07:55
@vinyselopal vinyselopal changed the title feature: show holidays and colour code in attendance calendar feat: show holidays and colour code in attendance calendar Mar 28, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 72.81%. Comparing base (b48cdcc) to head (b64d6b5).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1595      +/-   ##
===========================================
- Coverage    72.83%   72.81%   -0.02%     
===========================================
  Files          202      202              
  Lines        11169    11176       +7     
===========================================
+ Hits          8135     8138       +3     
- Misses        3034     3038       +4     
Files Coverage Δ
hrms/hr/doctype/attendance/attendance.py 69.12% <41.66%> (-1.30%) ⬇️

@ruchamahabal ruchamahabal force-pushed the add-holidays-to-attendance-calendar branch from e3d3958 to a7aab2a Compare April 5, 2024 15:50
@ruchamahabal ruchamahabal merged commit 218016a into develop Apr 5, 2024
8 checks passed
ruchamahabal added a commit that referenced this pull request Apr 5, 2024
…1595

feat: show holidays and colour code in attendance calendar (backport #1595)
ruchamahabal added a commit that referenced this pull request Apr 5, 2024
…1595

feat: show holidays and colour code in attendance calendar (backport #1595)
@ruchamahabal ruchamahabal deleted the add-holidays-to-attendance-calendar branch April 11, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show holidays in attendance calendar view Color coding for Absent and Half day in calendar view
3 participants