Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Desk + PWA): Geolocation in Employee Checkin #1642

Merged
merged 13 commits into from
May 29, 2024

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Apr 7, 2024

HR Settings

image

Employee Checkin (Desk)

geolocation-desk.mp4

Employee Checkin (Mobile App)

RPReplay_Final1712117350.MP4

Errors handled

image image

Also if the setting is disabled, geolocation fields are hidden

image image

@ruchamahabal ruchamahabal marked this pull request as draft April 7, 2024 18:02
@ruchamahabal ruchamahabal changed the title feat: Geolocation in Employee Checkin feat(Desk + PWA): Geolocation in Employee Checkin Apr 8, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 72.86%. Comparing base (a8f2490) to head (405f469).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1642      +/-   ##
===========================================
- Coverage    72.91%   72.86%   -0.06%     
===========================================
  Files          203      203              
  Lines        11244    11254      +10     
===========================================
+ Hits          8199     8200       +1     
- Misses        3045     3054       +9     
Files Coverage Δ
...ms/hr/doctype/employee_checkin/employee_checkin.py 90.37% <50.00%> (-3.23%) ⬇️

... and 2 files with indirect coverage changes

@muchai
Copy link

muchai commented Apr 17, 2024

Can one set coordinates(vicinity) within which an employee can be allowed to check in?
I.e. say, one wants to make sure one can only check-in while within certain coordinates.
Or maybe a report of, coordinates one is expected to check in from, vis a vis coordinates one actually checked in from.
A use case I have heard of.

@ruchamahabal
Copy link
Member Author

ruchamahabal commented Apr 18, 2024

Can one set coordinates(vicinity) within which an employee can be allowed to check in?
I.e. say, one wants to make sure one can only check-in while within certain coordinates.
Or maybe a report of, coordinates one is expected to check in from, vis a vis coordinates one actually checked in from.
A use case I have heard of.

Yes, geofencing will be the next feature we will work on after this gets released.

@ajiragroup
Copy link

Nice, but what if I turn on location spoofing (in android) and try to check in or out from acceptable areas when I am out relaxing ?
#1329

@ruchamahabal ruchamahabal marked this pull request as ready for review May 29, 2024 17:40
@ruchamahabal ruchamahabal merged commit 6f8d28c into frappe:develop May 29, 2024
9 of 12 checks passed
@ruchamahabal
Copy link
Member Author

Nice, but what if I turn on location spoofing (in android) and try to check in or out from acceptable areas when I am out relaxing ?

Currently the feature doesn't have anyway to detect this

ruchamahabal added a commit that referenced this pull request May 29, 2024
…1642

feat(Desk + PWA): Geolocation in Employee Checkin (backport #1642)
@ajiragroup
Copy link

Yes I understand and I checked if mock location is checked in the latest release. I am not into app development/PWA. But from my research, a simple check for "allow mock location" setting could do the trick. Would it be worth the HRMS team's time to spare a few hours? A mocked gps location is not of any use. I was concerned about this issue since I learnt the geo location attendance was in HRMS's future plan and I have raised issues multiple times. I would definitely contribute but this is out of my expertise area.

@ruchamahabal
Copy link
Member Author

I meant there is no way to know whether the location is mocked or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants