-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Desk + PWA): Geolocation in Employee Checkin #1642
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1642 +/- ##
===========================================
- Coverage 72.91% 72.86% -0.06%
===========================================
Files 203 203
Lines 11244 11254 +10
===========================================
+ Hits 8199 8200 +1
- Misses 3045 3054 +9
|
Can one set coordinates(vicinity) within which an employee can be allowed to check in? |
Yes, geofencing will be the next feature we will work on after this gets released. |
Nice, but what if I turn on location spoofing (in android) and try to check in or out from acceptable areas when I am out relaxing ? |
Currently the feature doesn't have anyway to detect this |
…1642 feat(Desk + PWA): Geolocation in Employee Checkin (backport #1642)
Yes I understand and I checked if mock location is checked in the latest release. I am not into app development/PWA. But from my research, a simple check for "allow mock location" setting could do the trick. Would it be worth the HRMS team's time to spare a few hours? A mocked gps location is not of any use. I was concerned about this issue since I learnt the geo location attendance was in HRMS's future plan and I have raised issues multiple times. I would definitely contribute but this is out of my expertise area. |
I meant there is no way to know whether the location is mocked or not. |
HR Settings
Employee Checkin (Desk)
geolocation-desk.mp4
Employee Checkin (Mobile App)
RPReplay_Final1712117350.MP4
Errors handled
Also if the setting is disabled, geolocation fields are hidden