Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: explicit time period for mark attendance #215

Merged

Conversation

scdanieli
Copy link
Contributor

@scdanieli scdanieli commented Nov 25, 2022

Status Quo: You can (bulk) mark attendance for employees via a dialog in the list view of attendance. But it's only possible for a specific month. And only for the current year. It's not possible to mark attendance for the day of execution. This causes the feature to not work properly around New Year's Eve.

before

After: Instead of a specific month, you can explicitly select a time period.

after

@scdanieli scdanieli force-pushed the explicit-time-period-for-mark-attendance branch from 1ba42ec to 8483608 Compare November 28, 2022 10:19
@scdanieli scdanieli marked this pull request as ready for review November 28, 2022 10:31
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #215 (e072edb) into develop (fed4366) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #215      +/-   ##
===========================================
+ Coverage    70.69%   70.71%   +0.01%     
===========================================
  Files          178      178              
  Lines         8981     9000      +19     
===========================================
+ Hits          6349     6364      +15     
- Misses        2632     2636       +4     
Impacted Files Coverage Δ
hrms/hr/doctype/attendance/attendance.py 71.23% <100.00%> (-1.73%) ⬇️
...rms/payroll/doctype/payroll_entry/payroll_entry.py 77.20% <0.00%> (-0.40%) ⬇️
hrms/payroll/doctype/salary_slip/salary_slip.py 87.08% <0.00%> (-0.06%) ⬇️
hrms/hr/doctype/hr_settings/hr_settings.py 71.42% <0.00%> (ø)
...yroll/doctype/salary_structure/salary_structure.py 80.70% <0.00%> (ø)
...nthly_attendance_sheet/monthly_attendance_sheet.py 95.66% <0.00%> (+0.06%) ⬆️
...tructure_assignment/salary_structure_assignment.py 82.55% <0.00%> (+0.30%) ⬆️
hrms/hr/doctype/shift_type/shift_type.py 89.41% <0.00%> (+2.35%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants