Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (fix too) Migrate to Stripe IntentPayment API #20

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

MorezMartin
Copy link

Migrate to IntentPayment API:

  • Possibility of using different mode of payments
  • Strong Client Authentification (SCA)
  • 3D Secure 2 OK 🚀 -> I'm french, many payments > 100€ didn't work with Charge API
  • Possibility to view payment status in Stripe Dashboard (can be enhanced later too)

Keeping the automatic validation of Payment Entries and Sales Invoices.
Have to add a payment_id field in Payment Request in ERPNext (maybe it can be achieve with this repos but i didn't success on this point)

Thanks in advance,
Sincerely yours,
Martin Morez

Squashing commits:

fix tab error

fix tab error

fix tab error

fix tab error

fix tab error

try to migrate to payment intents api

migrate to paymentintents api

migrate to paymentintent api

migrate to paymentintent api

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

Migrate to PaymentIntent API

Fix CSRF Token Error due to frappe not ready in creation of PaymentIntent when a user is connected

Migrate to Payment Intents API, Payment Intents OK, validation OK, TODO : link PI and PR, create payment in ERPNEXT

Migrate to PaymentIntent API : create Payment Entry whe payment suceed

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

fix indent error

fix indent error

enhance paymentintent validation

enhance paymentintent validation

enhance paymentintent validation

enhance paymentintent validation

enhance payment validation

enhance payment validation

enhance payment validation

enhance payment validation

enhance payment validation

enhance payment validation

enhance confirmation of payment intents

enhance payment intent confirmation

enhance payment intent confirmation

enhance payment intent confirmation

enhance payment intent confirmation

enhance payment intent confirmation

enhance payment intent confirmation

enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

finalize enhancement of payment intent confirmation and revue of stylesheets etc.

reuse of showMessage function to display errors in submitting form

redirect after success

delete payment-success.py

delete payment-success.py

fix tab error

fix tab error

fix tab error

fix tab error

fix tab error

try to migrate to payment intents api

migrate to paymentintents api

migrate to paymentintent api

migrate to paymentintent api

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

migrate to IntentPayments API

Migrate to PaymentIntent API

Fix CSRF Token Error due to frappe not ready in creation of PaymentIntent when a user is connected

Migrate to Payment Intents API, Payment Intents OK, validation OK, TODO : link PI and PR, create payment in ERPNEXT

Migrate to PaymentIntent API : create Payment Entry whe payment suceed

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

enhance paymentintent

fix indent error

fix indent error

enhance paymentintent validation

enhance paymentintent validation

enhance paymentintent validation

enhance paymentintent validation

enhance payment validation

enhance payment validation

enhance payment validation

enhance payment validation

enhance payment validation

enhance payment validation

enhance confirmation of payment intents

enhance payment intent confirmation

enhance payment intent confirmation

enhance payment intent confirmation

enhance payment intent confirmation

enhance payment intent confirmation

enhance payment intent confirmation

enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

test in enhance payment intent confirmation

finalize enhancement of payment intent confirmation and revue of stylesheets etc.

reuse of showMessage function to display errors in submitting form

redirect after success

delete payment-success.py

delete payment-success.py
@MorezMartin
Copy link
Author

@phot0n @chdecultot @nabinhait @rmehta ?

@Spixmaster
Copy link

@phot0n and @ankush, can you take a look at this and merge if it works?

@Spixmaster
Copy link

Spixmaster commented Aug 10, 2023

@MorezMartin Do you think this might fix #39? I tried to buy an item costing above 100 €. Did you receive the same error message?

@MorezMartin
Copy link
Author

MorezMartin commented Aug 11, 2023

@Spixmaster not sure it is, i think your problem is more related to the configuration of your Payement Gateway.
In an other way, when i was coding theses few lines, i faced problems with url generation clicking on payment button while a payment request was already existing, and i also had to change few lines related to this.
Try with a new fresh payment request, and try again with a new fresh installation if it is not concluant.
If you want, you can also try with my version installed -> https://github.com/MorezMartin/payments
Hope it could help.
Have a nice day,
Martin
PS : @phot0n @chdecultot @nabinhait @rmehta @ankush if you can take a look at this, il would be proud of adding my two cents to frappe / erpnext. Thanks in advance...

@Spixmaster
Copy link

@MorezMartin Thank you. I think I found the solution. The document could not be found for whatever reason. It probably had nothing to do with Stripe. I recreated the payment gateway and it worked. Here is a similar issue, frappe/erpnext#16928.

Nevertheless, this pull request should really be merged. It is the proper way of working with Stripe.

@Daandeve
Copy link

Any progress on this pull request? This will have a very positive impact on the software, in my country it is not common that people pay with a credit card

@MorezMartin
Copy link
Author

Merge conflicts after minor updates, i have not try this version yet since webshop is a separate repo, i will try it and modify if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants