feat: payer name & email from web form #47
+242
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention, my original motivation for the migration of custom fields to the "customizations API" (or whatever it's called) was not just because it's cleaner, but because Frappe automatically implements any changes that are made to the custom fields on "migrate". The exception to this, is that deleted fields should still be removed manually with some kind of migration script. |
batonac
changed the title
|
@ankush could I get a review on this so I know how to proceed? Thanks! |
Modify pyproject.toml and .gitignore to support newer versions of stripe.
…g debugging. Add custom_redirect_to_override option in stripe_settings.py finalize_request() so that the successful payment redirect address can be fully customized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add a feature to allow for sourcing the "Payer Name" and "Payer Email" in a payment gateway checkout form dynamically from web form fields.
Additionally, the Payment Form fields are cleaned up and moved to the dedicated custom fields JSON spec, instead relying on scripting to add and remove the custom fields. I believe this approach is cleaner, but I defer to the judgment of the maintainers in this regard.
The PR pre-supposes the removal of "Button Label" & "Button help" custom fields, as referenced in #4 and worked towards in #5.
Before (backend):
before.refactor_backend.mp4
After (backend):
after.refactor_backend.mp4
Before (frontend):
before.refactor_frontend.mp4
After (frontend):
after.refactor_frontend.mp4