Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.1 is always appended in the output path #129

Closed
IonicaBizau opened this issue Nov 10, 2016 · 4 comments
Closed

.1 is always appended in the output path #129

IonicaBizau opened this issue Nov 10, 2016 · 4 comments
Milestone

Comments

@IonicaBizau
Copy link

Thanks for the great app! ✨

I have a problem: the output path becomes <specified-path>.1. For instance:

electron-pdf path/to/RESULTS.md pdfs/results.pdf -c pdfs/assets/gh-markdown.css

Generates pdfs/results.pdf.1, but it actually contains the Markdown code, not the interpreted MD code.

Any ideas? Looks like a bug.

@codecounselor
Copy link
Collaborator

codecounselor commented Nov 10, 2016

You're right, I will change this if there is only a single PDF. The API supports multiple (url) inputs but there is no need to add a suffix for a single file.

@IonicaBizau
Copy link
Author

And probably it would be better to add the 1 before the .pdf extension: pdfs/results.1.pdf.

codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Nov 10, 2016
@codecounselor codecounselor modified the milestones: 0.13.2, 1.0.0 Nov 10, 2016
@codecounselor
Copy link
Collaborator

@IonicaBizau 1.0.0 is in npm now, see if this solves your issues.

@IonicaBizau
Copy link
Author

Thanks! Looking at the diff, that should be fixed. I cannot test it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants