Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no concurrency support when using session cookies #139

Closed
codecounselor opened this issue Dec 7, 2016 · 0 comments
Closed

no concurrency support when using session cookies #139

codecounselor opened this issue Dec 7, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@codecounselor
Copy link
Collaborator

Need to create a new (in-memory) session for every window that is created, otherwise concurrent requests will use the cookies applied to the single session created by the main process.

    // This creates a new session for every browser window, otherwise the same
    // default session is used from the main process which would break support
    // for concurrency
    // see http://electron.atom.io/docs/api/browser-window/#new-browserwindowoptions options.partition
    if( args.cookies ){
      defaultOpts.webPreferences.partition = uuid()
    }
@codecounselor codecounselor added this to the 1.1.1 milestone Dec 7, 2016
@codecounselor codecounselor self-assigned this Dec 7, 2016
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Dec 13, 2016
codecounselor added a commit that referenced this issue Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant