Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest Electron Version (4.0.2) #231

Closed
codecounselor opened this issue Jan 24, 2019 · 3 comments
Closed

Upgrade to latest Electron Version (4.0.2) #231

codecounselor opened this issue Jan 24, 2019 · 3 comments
Assignees

Comments

@codecounselor
Copy link
Collaborator

Its been a few years since bumping electron.
The latest version seems to fix the previous rendering issues.

The master branch should be updated to the latest and a new 4.0.x version of electron-pdf will be published

@codecounselor codecounselor self-assigned this Jan 24, 2019
codecounselor pushed a commit to codecounselor/electron-pdf that referenced this issue Jan 24, 2019
@mrohnstock
Copy link

mrohnstock commented Jan 31, 2019

Great that electron got updated! But for me electron-pdf 4.0.1 won't output anything :(.

Used the following command:

$ npm install -g electron-pdf
$ electron-pdf -v
v4.0.1
$ electron-pdf https://google.com test.pdf

Won't finish the command and waits ... for anything? Last tested and working version was 1.2.5.

Should I open a new issue for this?

Thanks!

@codecounselor
Copy link
Collaborator Author

This is what I get. Feel free to open an issue, but without some more details I'm not sure I can really help.
You can turn up the log levels as well, see the README.

 ~/projects> electron-pdf https://google.com test.pdf
Thu, 31 Jan 2019 15:47:27 GMT electronpdf:debug: { marginsType: 1,
  printBackground: true,
  printSelectionOnly: false,
  pageSize: 'A4',
  landscape: false }
Thu, 31 Jan 2019 15:47:27 GMT electronpdf:info: Export Complete
Shutting down...

@codecounselor
Copy link
Collaborator Author

If it helps, I noticed that on Ubuntu 18 I needed to install the libgtk-3-common package, which was a new requirement with the latest version of Electron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants