Add ability to export html as well (for SPA server-side rendering) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraserxu
requested changes
Dec 14, 2016
therabidbanana
force-pushed
the
master
branch
from
8ae5b0d
to
6206da5
Compare
| fs.writeFile(target, result, function (err) { | ||
| this.emit('window.capture.end', {file: target, error: err}) | ||
| this.emit('export-complete', {file: target}) | ||
| // REMOVE pdf-complete in 2.0 - keeping for backwards compatibility |
There was a problem hiding this comment.
You should remove the comment and the 'pdf-complete' event now since no one could have relied on it for html exports. I named it poorly to begin with and was only keeping it for backwards compatibility.
therabidbanana
force-pushed
the
master
branch
from
6206da5
to
7763da3
Compare
|
Thanks for the PR, it might be good to mention this in the |
|
Feedback hopefully all addressed - thanks for looking at it so quickly! |
fraserxu
approved these changes
Dec 14, 2016
|
👍 Looks good to me. I'm not using any of these features personally so I'll leave it to @codecounselor to merge. |
|
I have a couple of changes I am working on now, but will hopefully cut the 1.1.1 release within the week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're looking to replace our current setup for PDF generation with electron-pdf in our React-based single page app. Currently we use a two-step process to capture PDFs of our dashboards:
This process enabled us to also do server-side rendering for our dashboards, which is a neat way to allow HTML export for our React app in a way that doesn't require any JS for the end user. Ideally I'd like to tear out and replace the HTML export from PhantomJS and use the same Electron-based system for consistency, and this seemed like the easiest place to do it.
With these changes I can use the same event system to wait for both PDF and HTML to be rendered, etc.