Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pkgconfig #18

Merged
merged 1 commit into from Jan 4, 2021
Merged

add pkgconfig #18

merged 1 commit into from Jan 4, 2021

Conversation

nuomi2021
Copy link
Contributor

It's need by most of linux projects like ffmpeg

It's need by most of linux projects like ffmpeg
Name: libvvdec
Description: Fraunhofer Versatile Video Decoder (VVdeC)
Version: @PROJECT_VERSION@
Libs: -L${libdir} -lvvdec -lstdc++
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to leave a note that technically the user can choose the standard c++ library if they use clang, so this could be wrong, however, at the same time, there is no easy way to fix this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @1480c1,
Thanks for the suggstion.
Could you give more suggstion about how to fix this? add a comment in pkg-config?
thanks

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, there's no real way to solve this unless you are willing to parse the output of ${CXX} -v and try to find the c++ library

@adamjw24
Copy link
Member

Looks good to me.
I'd like the colleague who designed the build process to have a look, though, which possibly will only happen after the holidays.
So sorry if it takes a while to review this.

@nuomi2021
Copy link
Contributor Author

nuomi2021 commented Dec 22, 2020 via email

@adamjw24 adamjw24 merged commit eda9d3b into fraunhoferhhi:master Jan 4, 2021
@nuomi2021
Copy link
Contributor Author

thank you both for helping

@adamjw24
Copy link
Member

adamjw24 commented Jan 4, 2021

Thank you for the merge request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants