Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigating pydantic v2 upgrade #40

Closed
wants to merge 2 commits into from

Conversation

iamchrisearle
Copy link
Collaborator

Description

Experimental branch showing known issues with updating to pydantic V2

Closes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A
  • Test B

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Next Steps

  • Assign a reviewer based on the code owner document.

  • Once your review is approved, merge and delete the feature branch

On behalf of the Modis Tools Dev Team, thank you for your hard work! ✨

@iamchrisearle
Copy link
Collaborator Author

For when we do upgrade to higher pydantic versions, this fix will help with coercing the URL to behave like a string:

pydantic/pydantic#7186 (comment)

@jamie-sgro
Copy link
Member

@cearlefraym what's the status of this PR?

@iamchrisearle
Copy link
Collaborator Author

@cearlefraym what's the status of this PR?

This is for knowledge transfer, it can be closed. If/when switching to pydantic v2, this is important behavior to need to build around.

@jamie-sgro jamie-sgro closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants