-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*Blacklisting* certain attributes #80
Comments
Currently, no it doesn't. I'll look into this though as there's probably something we can do here about standardising the way execCommand uses some commands like align. See #82 and #68. Though I probably can only change this in 1.2.0 due to my fork of angular-sanitize that allows specific santised style tags - depending on how my testing goes. |
Added Rangy as Optional library - Gives better activeState selection and more flexibility to tools plugins. Completely optional. taBind and taSanitize tests #33 Fixed the use of ‘align’ attribute which is supposed to be depreciated in HTML5, changed to add in ‘text-align’ style as valid attribute. issue highlighted from #80 Update model on cut/paste #79 Add in some toolbar focus fixes from test cases. Moved a lot of for loops to anglular.forEach as it’s tidier.
As an aside, I looked around and the align attribute apparently is depreciated for this use, I've modified textAngular to automatically strip out align tags and replace with corresponding style attribute in v1.2.0. No idea how we'd do blacklisting by implementation though. I have some ideas but I'm a bit hesitant to rewrite large amounts of the angular-sanitize code just at the moment. |
Quick update on this, I've seen a PR across on the angular.js repo that will do custom whitelisting. I think I'll push this out till they add that in which probably will be in Angular 1.3.0 which means I'll have to do a textAngular 1.3.0 to match, posssibly. |
Just to say I am watching this, editing textAngular-sanitize is starting to be the most pressing pain point in textAngular so I think I'll have to do something myself (then maybe submit a PR to the main repo) |
Hey, I've noticed there is some odd behaviour to do with ol/ul lists and content with align=left on it. This has been observed in ie9 only. To reproduce paste in the following HTML
The cursor after the first li sits below the number. This content was originally pasted in from word and I was wondering if textangular provided a facility to ward against specific tags and attributes. In this case i'd like it to remove all "align" attributes.
The text was updated successfully, but these errors were encountered: