Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing issue #616 #1174

Closed
wants to merge 1 commit into from
Closed

fixing issue #616 #1174

wants to merge 1 commit into from

Conversation

hike-dev
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f8d466e on Hike-zzz:master into fe544a6 on fraywing:master.

@@ -175,6 +175,9 @@ angular.module('textAngular.DOM', ['textAngular.factories'])
}
}
}
_nodes = _nodes.filter(function(value, index, self) {
return self.indexOf(value) === index;
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, you're only selecting the ones the it's index correspond to it's actual index?
To prevent arrays populated like arr[10] = 1, arr[20] = 2. Is that right?
If so, could you explain why that's necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem has been in a multiple of child inline elements with selected block element.
All child inline elements needs a block wrapper. My fix prevents duplication of created wrappers.
I think - it may be more correct decision. But I opted this solution for its simplicity and clarity.

@pbassut
Copy link
Contributor

pbassut commented May 12, 2016

@Hike-zzz Hey, thanks very much for the PR and keep this project well maintained!
I added some notes to your code. Mind commenting back?

@JoelParke
Copy link
Collaborator

Thanks -- I merged this into the master and committed.

@JoelParke JoelParke closed this Jul 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants