Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Austria to list of countries #308

Merged
merged 2 commits into from Oct 12, 2021

Conversation

rboyatt
Copy link
Contributor

@rboyatt rboyatt commented Oct 10, 2021

Adding Austria to list of countries - it's not currently including and causing 'Unknown' category in list of countries.

Note this commit is based on earlier changes to fix new parkrun page structure (but those are not yet in master).

@fraz3alpha
Copy link
Owner

Thanks @rboyatt :)

It seems like there has to be a better way to add a new country than all the changes all over the place we currently have to make.

Before the next country comes around, do you have a preference to either a) having a script to put the things in the right places, or b) move things around to have a single thing to add (perhaps one file?) to add a new country? I can add it to the backlog and have a think about how to accommodate it.

@rboyatt
Copy link
Contributor Author

rboyatt commented Oct 10, 2021

I thought if you were heading for a release it was a useful one to sneak in :) Even after reading the instructions, I still missed a step! The second option - rearranging things into one location sounds preferable, as probably less brittle than a script. It doesn't seem too much work to get (most) country details into one file?

@fraz3alpha fraz3alpha changed the base branch from master to 2021-10-website-changes October 12, 2021 21:29
@fraz3alpha
Copy link
Owner

I've modified this PR to be based on the branch we've got the other fixes in, so it's just showing the changes for Austria now.

@fraz3alpha
Copy link
Owner

Going through the steps we have here: https://github.com/fraz3alpha/running-challenges/tree/master#adding-a-new-country and checking the steps are correct, and if we've got everything.

Copy link
Owner

@fraz3alpha fraz3alpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll merge it into the dev branch for the current set of changes

@fraz3alpha fraz3alpha merged commit 6ed59fd into fraz3alpha:2021-10-website-changes Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants