Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sponsors are not centered on the Branding page #591

Closed
1ceit opened this issue Jan 23, 2024 · 5 comments
Closed

Sponsors are not centered on the Branding page #591

1ceit opened this issue Jan 23, 2024 · 5 comments
Labels
content graphical

Comments

@1ceit
Copy link
Member

1ceit commented Jan 23, 2024

Screen Shot 2024-01-23 at 9 59 41 AM The sponsors aren't centered, this is only on the branding page.
@1ceit
Copy link
Member Author

1ceit commented Jan 29, 2024

I've been sifting through the code and struggling to find what is causing this. @ErikBoesen Do you think you could help?

@ErikBoesen
Copy link
Member

It's this line: https://github.com/frc1418/frc1418.github.io/blob/master/css/branding.sass#L7

In the future try using your browser developer tools and unchecking different rules to see what might make the view change as you desire. In this case it might also help to focus on rules that come from branding.css/sass.

MyaTaheri added a commit that referenced this issue Feb 7, 2024
@MyaTaheri
Fix issue #591 + add Rihanna's Picture
20d3749
MyaTaheri added a commit that referenced this issue Feb 7, 2024
@MyaTaheri
Fix issue #591 + add Rihanna's Picture
c8cb8c1
1ceit pushed a commit that referenced this issue Feb 8, 2024
@MyaTaheri
add rihanna's picture, removed old members, fix issue #591 (#597)
33a49ae 
* Added Oliver Hardi's Image

* update members list

* added gael's image

* Fix issue #591 + add Rihanna's Picture

* Fix issue #591 + add Rihanna's Picture
@1ceit
Copy link
Member Author

1ceit commented Feb 8, 2024

Screen Shot 2024-02-08 at 11 09 51 AM I dont know if this did this but now this is an issue

@ErikBoesen
Copy link
Member

That CSS rule was there for a reason. It was just overly broad. Instead of removing it you should make sure it only applies to the tables within the main page content. @MyaTaheri

@1ceit
Copy link
Member Author

1ceit commented Mar 12, 2024

This has been fixed

@1ceit 1ceit closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
content graphical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ErikBoesen @1ceit