Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow for multiple root level ‘component’ folders #103

Closed
paulrobertlloyd opened this issue Jul 28, 2016 · 7 comments · Fixed by #642
Closed

Feature request: Allow for multiple root level ‘component’ folders #103

paulrobertlloyd opened this issue Jul 28, 2016 · 7 comments · Fixed by #642

Comments

@paulrobertlloyd
Copy link
Contributor

Within my components folder, I have a set of components which are top-level (page) assemblies. Conceptually, these are still components, but in terms of my deliverable, they are markedly different. Currently I have made the distinction in the navigation by using italics:

screen shot 2016-07-28 at 10 51 56

Ideally, the Web UI would allow me to place them under a top level heading instead, i.e.:

screen shot 2016-07-28 at 10 51 22

This might be a Mandelbrot issue (and one that could be solved by using a custom theme), but it’s worth pointing out that allowing only a single component folder is a notable opinion within Fractal.

@sbaechler
Copy link

What about even giving up the strict separation between Handlebars 'Components' and Markdown 'Documentation'? Ideally Fractal would render whatever you throw at it.

@allmarkedup allmarkedup added this to the 2.0 milestone Aug 3, 2017
@allmarkedup allmarkedup added this to Inspector in [v2] Fractal Core Aug 7, 2017
@allmarkedup allmarkedup moved this from Inspector to Fractal core in [v2] Fractal Core Aug 7, 2017
@allmarkedup allmarkedup moved this from Planning to In progress in [v2] Fractal Core Aug 16, 2017
@allmarkedup allmarkedup moved this from In progress to Completed in [v2] Fractal Core Sep 1, 2017
@stale
Copy link

stale bot commented Jul 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 13, 2018
@stale stale bot closed this as completed Jul 20, 2018
mihkeleidast pushed a commit that referenced this issue May 21, 2020
update font files to fix error in firefox
mihkeleidast pushed a commit that referenced this issue May 21, 2020
update font files to fix error in firefox
mihkeleidast pushed a commit that referenced this issue May 23, 2020
update font files to fix error in firefox
mihkeleidast pushed a commit that referenced this issue May 23, 2020
update font files to fix error in firefox
@LeBenLeBen LeBenLeBen removed this from the 2.0 milestone May 23, 2020
@LeBenLeBen LeBenLeBen reopened this May 23, 2020
@mihkeleidast
Copy link
Member

Solution proposal

  • Allow specifying root: true in a collection config.
  • By default, root is set to false
  • If a collection has been set to be root, it will be pulled out from it's filesystem tree location in the navigation to root. It should not be rendered in its original location.
  • If there are no non-root collections or no entities left in the default tree, then only the title should not be rendered. E.g. the usecase when I have src/components and src/pages collections and both have been set to be root.

WDYT?

@mihkeleidast mihkeleidast self-assigned this Jun 15, 2020
@paulrobertlloyd
Copy link
Contributor Author

As the person responsible for opening this issue, I guess I should comment.

While it’s great to see these old feature requests get resolved, I haven’t used Fractal in years, so have zero context – or recall – regarding this issue. So, please do go ahead without me. 🙂

@mihkeleidast
Copy link
Member

Ah don't worry about it - the issue is still open because it looks like a great improvement. The proposal was not directed at you, rather at my co-maintainers. I find it's better to talk through the proposals before diving into code :)

@LeBenLeBen
Copy link
Member

@mihkeleidast I guess that would work and without requiring any breaking change for a first version.

If we rather want that for the next major version, a single folder (no more components VS docs) that contains the whole tree might be better in the sense that the file system and the UI are perfectly aligned all the time.

@stale
Copy link

stale bot commented Aug 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants